Updates to Spectral & TimeFrequency #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomDonoghue
requested review from
rdgao and
voytek
and removed request for
voytek and
rdgao
rdgao
approved these changes
Mar 16, 2019
|
Alright - merging this one in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non API breaking refactors and clean ups of the spectral & time frequency module. (Somewhat related to #140 - but nothing that breaks anything here).
Main changes:
filter(get rid of duplicated code withintimefrequency, and across the package. This includes moving & renaming a 'infer_passtype' from tf -> filt.Notably, this fixes a bug in which the old version would fail out if you tried to discard outliers in compute_spectrum with a 1d signal.