-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for v2.0.0 #150
Updates for v2.0.0 #150
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I said, I don't have time to review code in detail, but this all broadly looks good.
@rdgao - do you have thoughts defining filter ranges Also: when you plot a filter kernel, what do the axes represent? What should the labels be? |
Another question - why do we support passing in an array of values as an aperiodic signal into the combined functions? If you already have an aperiodic signal, in an array, then you can just simulate an oscillation and add it to the aperiodic (using our normalized by variance function, if desired). So - y'all cool with dropping array inputs to combined funcs? |
… run warning checks
okay I just saw there are 110 file changes so let's talk about this in lab tomorrow lol |
Add Plotting Funcs
Update paper to reflect 2.0 orgs
Okay @rdgao - I fixed up the main topics from the IRL code review, which is to fix how the aperiodic rotation deals with f=0, and temporarily remove periodic sims that don't work with oscillation kernels / the new approach - I'll open a branch to merge that back in with the new outline. Otherwise, everything in here has had an overview sign off, and this PR is getting ridiculous, so, now that 1.1.X is released, I'm going to merge this (officially breaking master from 1.0, and moving it to 2.0). |
Responds to #140
WARNING: This is an API breaking update. Don't merge until we're all sure we're on board, and also until after we've tagged and released a 1.1.0 release.
Okay - this is getting fairly close (without the test overhaul yet).
A couple open questions:
filt
uses the namefc
for defining filter range, but other modules that callfilt
, for exampletime-frequency
use the namef_range
, which is a bit inconsistent. Should we consolidate on one name?Note: not having updated the tests properly yet, I've just turned off a few tests where the old consistency tests became out of data, so confidence in this exact version should be relatively low.
At this stage - perhaps not ready for a proper / formal review, but if people want to skim through - start checking if y'all are on board with the things that are changing, and also if there are things that seemed to be missed so far. Starting trying out using it / stress tests and ideas on testing overhaul also very welcome!