Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] - Update standard for compute n_samples for simulations #250

Merged
merged 15 commits into from
Mar 15, 2021
Merged

[BUG] - Update standard for compute n_samples for simulations #250

merged 15 commits into from
Mar 15, 2021

Commits on Feb 22, 2021

  1. use helper function to compute nsamples

    @TomDonoghue
    TomDonoghue committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    9f7e1e0 View commit details
    Browse the repository at this point in the history

  2. update n_samples convention to round up:

    @TomDonoghue
    TomDonoghue committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    94cfd07 View commit details
    Browse the repository at this point in the history

  3. use compute_nsamples for sig truncating

    @TomDonoghue
    TomDonoghue committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    5f61b40 View commit details
    Browse the repository at this point in the history

  4. add more tests for sim periodic lengths

    @TomDonoghue
    TomDonoghue committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    09517ea View commit details
    Browse the repository at this point in the history

  5. consolidate on using compute_nsamples

    @TomDonoghue
    TomDonoghue committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    c4a565e View commit details
    Browse the repository at this point in the history

  6. extend testing of sim lengths

    @TomDonoghue
    TomDonoghue committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    9fa64a2 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2021

  1. update convention to round n_samples down

    @TomDonoghue
    TomDonoghue committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    50d0c93 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into simlen

    @TomDonoghue
    TomDonoghue committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    ee82d9b View commit details
    Browse the repository at this point in the history

  3. add test for concatenation issues

    @TomDonoghue
    TomDonoghue committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    39d0487 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'simlen' of https://github.com/neurodsp-tools/neurodsp i… 

    …nto simlen
    @TomDonoghue
    TomDonoghue committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    aa0122e View commit details
    Browse the repository at this point in the history

  5. extend concatenation testing

    @TomDonoghue
    TomDonoghue committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    0086f7a View commit details
    Browse the repository at this point in the history

  6. reconsolidate (again) on rounding up n_samples

    @TomDonoghue
    TomDonoghue committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    0661a77 View commit details
    Browse the repository at this point in the history

  7. revert n_seconds_cycle to appropriate estimation

    @TomDonoghue
    TomDonoghue committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    e81bf9e View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2021

  1. fix bug in create_times that led to wrong durations with start_val

    @TomDonoghue
    TomDonoghue committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    fcbd89a View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2021

  1. add cycle specific test n_seconds setting

    @TomDonoghue
    TomDonoghue committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    1f09fec View commit details
    Browse the repository at this point in the history