Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error while processing mouse data #42

Closed
kvshams opened this issue Jul 9, 2021 · 5 comments
Closed

error while processing mouse data #42

kvshams opened this issue Jul 9, 2021 · 5 comments

Comments

@kvshams
Copy link

kvshams commented Jul 9, 2021

getting zero gene ortholog

ctd2 = prepare.quantile.groups(ctd,specificity_species = "mouse",
                               gwas_species = "human", numberOfBins=40)
[1] "Dropping all genes that do not have 1:1 homologs between the two species"
[1] "Species for which homology classes are available:"
character(0)
[1] "Available species options:"
[1] all    simple
<0 rows> (or 0-length row.names)
Error in check.species(requestedSpecies = species1, allSpecies = allHomologs$`Common Organism Name`): ERROR: species does not match available options
Traceback:

1. prepare.quantile.groups(ctd, specificity_species = "mouse", gwas_species = "human", 
 .     numberOfBins = 40)
2. One2One::analyse.orthology(specificity_species, gwas_species, 
 .     allHomologs)   # at line 7 of file <text>
3. check.species(requestedSpecies = species1, allSpecies = allHomologs$`Common Organism Name`)
4. stop("ERROR: species does not match available options")
5. 

While checking the code, it may be associated with One2One packages load.homologs.r

    hom_vert = read.table("http://www.informatics.jax.org/downloads/reports/HOM_AllOrganism.rpt",sep="\t",stringsAsFactors = FALSE,quote="") ```

 as the column header has been changed. Not sure what was the previous and how that column handled for the downstream for debugging.







@Al-Murphy
Copy link
Collaborator

Hi @kvshams,

Thanks for letting us know, I am able to replicate the error and am looking into a fix now. I'll update when it is resolved.

Kind regards,
Alan.

@kvshams
Copy link
Author

kvshams commented Jul 12, 2021

@Al-Murphy Thanks.... it worked out well with just fixing the column name and it worked well. I included those changes in the pull at One2One.

@Al-Murphy
Copy link
Collaborator

Thanks @kvshams, we are investigating to see if the data has changed along with the column header, it appears there is a significant difference in the new dataset size. If you're interested, see the issue here:

NathanSkene/One2One#3

@Al-Murphy
Copy link
Collaborator

This issue has been resolved thanks to a fix to the OnetoOne package. @bschilder can you confirm if you plan to replace the use of OnetoOne down the line in your MAGMA_celltyping branch? @NathanSkene mentioned you might?

@bschilder
Copy link
Collaborator

@Al-Murphy sorry for the late reply, these were all getting sent to my spam folder.

Yes, I am planning on updating prepare.quantile.groups() to take advantage of the upgrades in interspecies gene conversion in the DelayedArray branch of EWCE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants