Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force new install of local repo #86

Open
bschilder opened this issue Oct 11, 2023 · 3 comments
Open

Force new install of local repo #86

bschilder opened this issue Oct 11, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@bschilder
Copy link
Collaborator

I noticed with autoCV that the local repo wasn't getting reinstalled when the version was detected to be the same as before (0.99.0).

https://github.com/bschilder/autoCV/actions/runs/6484810363/job/17609460418#step:4:599

Skipping install of 'autoCV' from a local remote, the SHA1 (0.99.0) has not changed since last install.
  Use `force = TRUE` to force installation

Bumping the version to 0.99.1 fixed this, but I think the default behaviour should be to
always reinstall, because developers aren't going to necessarily bump the version every time they make a push.

@bschilder bschilder self-assigned this Oct 11, 2023
@bschilder bschilder added the enhancement New feature or request label Oct 11, 2023
@bschilder
Copy link
Collaborator Author

Done in dev:

remotes::install_local(repos=repos, dependencies=TRUE, build_vignettes=FALSE, upgrade=TRUE, force=TRUE)

@js2264
Copy link
Contributor

js2264 commented Apr 23, 2024

Hey Brian, any reason why this was reverted to force = FALSE? CAnnot figure out why, but it seems to cause trouble again...

@bschilder
Copy link
Collaborator Author

bschilder commented Apr 23, 2024

There were a couple of reasons, and I can see arguments for either as a default. but i think the real answer is that users should have control over this param, which ive implemented on rworkflows dev but havent released yet.

some pros of force=FALSE:

cons:

  • issues described in this thread

I'm about to submit my thesis next week but I can get to this after that. sorry about the issues @js2264 !

@bschilder bschilder reopened this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

2 participants