corrected index of rates_exc in computation of IA_rhs #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #237 +/- ##
==========================================
+ Coverage 93.41% 93.50% +0.09%
==========================================
Files 51 51
Lines 4401 4401
==========================================
+ Hits 4111 4115 +4
+ Misses 290 286 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@lenasal could you please rebase on the new master? I fixed unrelated errors with numpy. |
|
rebased on new master branch |
caglorithm
reviewed
Jul 14, 2023
| @@ -514,7 +514,7 @@ def timeIntegration_njit_elementwise( | |||
| mufi_rhs = (mui - mufi[no]) / tau_inh | |||
|
|
|||
| # rate has to be kHz | |||
| IA_rhs = (a * (Vmean_exc - EA) - IA[no, i - 1] + tauA * b * rates_exc[no, i] * 1e-3) / tauA | |||
There was a problem hiding this comment.
Are you sure that this is correct?
Compare rates_exc[:, i] with Vmean_exc:
rates_exc[no, i] = interpolate_values(precalc_r, xid1, yid1, dxid, dyid) * 1e3
Vmean_exc = interpolate_values(precalc_V, xid1, yid1, dxid, dyid)They are the same time step. rates_exc[no, i-1] is too old.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... as discussed with Nikola :-)