-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
corrected index of rates_exc in computation of IA_rhs #237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #237 +/- ##
==========================================
+ Coverage 93.41% 93.50% +0.09%
==========================================
Files 51 51
Lines 4401 4401
==========================================
+ Hits 4111 4115 +4
+ Misses 290 286 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@lenasal could you please rebase on the new master? I fixed unrelated errors with numpy. |
rebased on new master branch |
@@ -514,7 +514,7 @@ def timeIntegration_njit_elementwise( | |||
mufi_rhs = (mui - mufi[no]) / tau_inh | |||
|
|||
# rate has to be kHz | |||
IA_rhs = (a * (Vmean_exc - EA) - IA[no, i - 1] + tauA * b * rates_exc[no, i] * 1e-3) / tauA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure that this is correct?
Compare rates_exc[:, i]
with Vmean_exc
:
rates_exc[no, i] = interpolate_values(precalc_r, xid1, yid1, dxid, dyid) * 1e3
Vmean_exc = interpolate_values(precalc_V, xid1, yid1, dxid, dyid)
They are the same time step. rates_exc[no, i-1]
is too old.
... as discussed with Nikola :-)