allow for two point (single section) SWC somas #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add test for simple two point swc soma * only test for neuromorpho three point soma if the SWC file has a soma of three points
mgeplf
commented
Apr 7, 2021
| soma3geom = 0 | ||
| if (nsoma_pts == 3 && pix2ix(1) == 0 && pix2ix(2) == 0) { |
There was a problem hiding this comment.
previously, for 2 points, this would cause an error:
NEURON: subscript out of range x
near line 0
}
^
Import3d_SWC_read[13].pix2ix(2)
Import3d_SWC_read[13].check_soma3geom(2, Vector[1450])
Import3d_SWC_read[13].sectionify()
Import3d_SWC_read[13].input("temp.tmp")
My hoc isn't great, but I take it that it doesn't do short-circuit evaluation?
mgeplf
commented
Apr 7, 2021
|
The original SWC format paper (An on-line archive of reconstructed hippocampal neurons) says this: So, I believe that a single cylinder is an allowable value for the soma. |
nrnhines
approved these changes
Apr 7, 2021
|
thanks @mgeplf! |
asanin-epfl
added a commit
to BlueBrain/MorphIO
that referenced
this pull request
Apr 8, 2021
due to neuronsimulator/nrn#1144 This reverts commit 24d7c1d
This was referenced Apr 8, 2021
asanin-epfl
added a commit
to BlueBrain/MorphIO
that referenced
this pull request
Apr 8, 2021
due to neuronsimulator/nrn#1144 This reverts commit 24d7c1d
alexsavulescu
pushed a commit
that referenced
this pull request
Apr 13, 2021
* add test for simple two point swc soma * only test for neuromorpho three point soma if the SWC file has a soma of three points
alexsavulescu
pushed a commit
that referenced
this pull request
Apr 30, 2021
* add test for simple two point swc soma * only test for neuromorpho three point soma if the SWC file has a soma of three points
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a soma of three points