Random123 behavior tests

[atemerev]

Included a smoke test to see if Random123 actually works (it is fully deterministic, so we should get exactly the same output for a particular set of parameters).

Probably should also include some functional tests to see if our distribution generators work too.

[azure-pipelines]

✔️ ff25ae7 -> Azure artifacts URL

[azure-pipelines]

✔️ e3befee -> Azure artifacts URL

[codecov]

Codecov Report

Attention: Patch coverage is 95.23810% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.20%. Comparing base (8383628) to head (ea1930c).

Files	Patch %	Lines
test/coreneuron/unit/random/test_random.cpp	95.23%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2773      +/-   ##
==========================================
- Coverage   67.20%   67.20%   -0.01%     
==========================================
  Files         564      565       +1     
  Lines      104246   104277      +31     
==========================================
+ Hits        70060    70080      +20     
- Misses      34186    34197      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pramodk]

Nice!

I have few minor comments that we can address and we get this merged.

[azure-pipelines]

✔️ 2a588a2 -> Azure artifacts URL

[atemerev]

The test is not working with OpenACC/OpenMP, because it is exactly the failure mode of stateful RNGs in the parallel environment :) I can rewrite it properly, but the question is what exactly we should test, there are many options (e.g. there should be no duplicate values etc).

[nrnhines]

because it is exactly the failure mode of stateful RNGs in the parallel environment

The usage is always a separate stream for every physical element that needs a random stream. All those physical elements are potentially computed in parallel. So I think it is most realistic for your test to have a double loop where the outer loop represents time steps and the inner loop is over elements. i.e. something like

for (int istep = 0; i < nstep; ++istep) {
    nrn_pragma_acc(parallel loop copy(res [0:nstream]) deviceptr(s))
    for (int istream = 0; i < nstream; ++istream) {
        res[istep][istream] = nrnran123_dblpick(s[istream]);
    }
}

Every res element is statistically independent of all the other res elements in the interval 0 to 1 (I'm not sure 0.0 or 1.0 are part of that interval.) And res should be the same regardless of the degree of omp or acc parallelization.

[azure-pipelines]

✔️ ffe0d2b -> Azure artifacts URL

[azure-pipelines]

✔️ acd61d8 -> Azure artifacts URL

[azure-pipelines]

✔️ 0e19aa1 -> Azure artifacts URL

[azure-pipelines]

✔️ fd9bb33 -> Azure artifacts URL

[azure-pipelines]

✔️ 69d9d5b -> Azure artifacts URL

[sonarcloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[azure-pipelines]

✔️ ea1930c -> Azure artifacts URL

[bbpbuildbot]

Logfiles from GitLab pipeline #206884 (:white_check_mark:) have been uploaded here!

Status and direct links:

• ✅ mac_m1_cmake_build: [cmake, ON, OFF, OFF, address]
• ✅ spack_setup
• ✅ build:nmodl
• ✅ build:neuron:nmodl:intel:legacy
• ✅ build:neuron:nmodl:intel:shared
• ✅ build:neuron:nmodl:nvhpc:acc:legacy
• ✅ build:neuron:nmodl:nvhpc:acc:shared
• ✅ build:neuron:nmodl:nvhpc:omp:legacy
• ✅ build:neuron:nmodl:nvhpc:omp
• ✅ test:neuron:nmodl:intel:legacy
• ✅ test:neuron:nmodl:intel:shared
• ✅ test:neuron:nmodl:nvhpc:acc:legacy
• ✅ test:neuron:nmodl:nvhpc:acc:shared
• ✅ test:neuron:nmodl:nvhpc:omp:legacy
• ✅ test:neuron:nmodl:nvhpc:omp