Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put max version of python to 3.12 for GHA #2868

Merged
merged 8 commits into from
May 3, 2024
Merged

Conversation

alkino
Copy link
Member

@alkino alkino commented May 3, 2024

No description provided.

@JCGoran
Copy link
Contributor

JCGoran commented May 3, 2024

From the looks of it, we need at least 2 fixes:

  • install setuptools in CI before installing MUSIC (easy)
  • replace the removed imp module used by MUSIC by importlib (requires changes upstream)

Copy link

✔️ db9739c -> Azure artifacts URL

Copy link

✔️ b8c08cb -> Azure artifacts URL

Copy link

✔️ aded7b3 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.17%. Comparing base (8a9bada) to head (171e142).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2868      +/-   ##
==========================================
- Coverage   67.19%   67.17%   -0.02%     
==========================================
  Files         563      563              
  Lines      104283   104282       -1     
==========================================
- Hits        70074    70053      -21     
- Misses      34209    34229      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@JCGoran JCGoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's good to test it out more thoroughly on 3.12 now that it's been out for a while.

@alkino alkino enabled auto-merge (squash) May 3, 2024 15:56
Copy link

✔️ 171e142 -> Azure artifacts URL

@alkino alkino merged commit 0a7b890 into master May 3, 2024
37 checks passed
@alkino alkino deleted the cornu/gha_python_3_12 branch May 3, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants