Header Hygiene

[mgeplf]

• have multicore.h declare all the functions that are used elsewhere
• instead of extern decl; elsewhere, #include "multicore.h"
• cleanup

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[azure-pipelines]

✔️ 2fef28d -> Azure artifacts URL

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.25%. Comparing base (1042b2c) to head (2fef28d).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2937   +/-   ##
=======================================
  Coverage   67.25%   67.25%           
=======================================
  Files         570      570           
  Lines      104949   104949           
=======================================
+ Hits        70580    70581    +1     
+ Misses      34369    34368    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bbpbuildbot]

Logfiles from GitLab pipeline #218769 (:white_check_mark:) have been uploaded here!

Status and direct links:

• ✅ mac_m1_cmake_build: [cmake, ON, OFF, OFF, address]
• ✅ spack_setup
• ✅ build:nmodl
• ✅ build:neuron:nmodl:intel:legacy
• ✅ build:neuron:nmodl:intel:shared
• ✅ build:neuron:nmodl:nvhpc:acc:legacy
• ✅ build:neuron:nmodl:nvhpc:acc:shared
• ✅ build:neuron:nmodl:nvhpc:omp:legacy
• ✅ build:neuron:nmodl:nvhpc:omp
• ✅ test:neuron:nmodl:intel:legacy
• ✅ test:neuron:nmodl:intel:shared
• ✅ test:neuron:nmodl:nvhpc:acc:legacy
• ✅ test:neuron:nmodl:nvhpc:acc:shared
• ✅ test:neuron:nmodl:nvhpc:omp:legacy
• ✅ test:neuron:nmodl:nvhpc:omp

[1uc]

Thank you, to me this makes sense and works towards a standard way of organizing code into files and directories.