Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update coreneuron with nmodl and improve sub-modules cloning #878

Merged
merged 4 commits into from
Jan 10, 2021
Merged

Update coreneuron with nmodl and improve sub-modules cloning #878

merged 4 commits into from
Jan 10, 2021

Conversation

pramodk
Copy link
Member

@pramodk pramodk commented Dec 21, 2020

  • CoreNEURON and nmodl are updated to latest master
  • External project helper module is improved
    • avoid hardcoding third project directory as same cmake module
      can be used by internal projects like coreneuron and nmodl
    • error if git submodule update is failed
    • avoid recursive cloning as each project initialize necessary
      submodules

@pramodk pramodk marked this pull request as ready for review January 5, 2021 14:12
pramodk and others added 3 commits January 10, 2021 09:19
@pramodk
Update coreneuron with nmodl and improve sub-modules cloning
2b2aa3f 
* CoreNEURON and nmodl are updated to latest master
* External project helper module is improved
  - avoid hardcoding third project directory as same cmake module
    can be used by internal projects like coreneuron and nmodl
  - error if git submodule update is failed
  - avoid recursive cloning as each project initialize necessary
    submodules
@iomaganaris @pramodk
Updated CoreNEURON to latest master
91374b2
@pramodk
Update coreneuron to latest master again
0608546
@pramodk pramodk force-pushed the pramodk/coreneuron-nmodl-update branch from d3bc484 to 0608546 Compare January 10, 2021 08:20
@pramodk pramodk requested a review from nrnhines January 10, 2021 13:38
nrnhines
nrnhines approved these changes Jan 10, 2021
View reviewed changes
Copy link
Member

@nrnhines nrnhines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice that when -DNRN_ENABLE_TESTS=ON but -DNRN_ENABLE_CORENEURON=OFF that coreneuron and all its submodules are still cloned. Is this a good place to avoid that?

@pramodk
Copy link
Member Author

pramodk commented Jan 10, 2021

Let me test that

@nrnhines
Copy link
Member

I'm sorry. I misremembered. It was make docs that clones it.

@nrnhines nrnhines merged commit 42c8683 into master Jan 10, 2021
@nrnhines nrnhines deleted the pramodk/coreneuron-nmodl-update branch January 10, 2021 16:04
@pramodk
Copy link
Member Author

pramodk commented Jan 10, 2021

Ah ok! good!

@alexsavulescu alexsavulescu mentioned this pull request Apr 26, 2021
Closed
olupton added a commit that referenced this pull request Dec 7, 2022
@olupton
Configure sanitizers in CMake (#878)
0e5bf0d 
* Use sanitizer helpers from hpc-coding-conventions.
* Integrate sanitizer-specific configuration into CMake
  configuration so less magic needs to be done externally.
* Add more UBSan checks + exclusions.
* Make sanitizer GitHub Actions configuration simpler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrnhines nrnhines nrnhines approved these changes

@iomaganaris iomaganaris iomaganaris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pramodk @nrnhines @iomaganaris