-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
code coverage setup - codecov.io #962
Conversation
Report here: https://codecov.io/gh/neuronsimulator/nrn/tree/54fdb229de986666e2ac3c0c2d9615c420677ecd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just FYI I couldn't use pytest-cov for all our python tests because for some of them we are passing extra arguments. Will address that in future PRs (I also plan on working a bit more on testing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition! I just have a few minor issues...
If you click on e.g. |
Works for me: Anyway, we need to have a build for master as starting base. We can check it out after we merge. |
We saw similar thing for coreneuron. I think after merge when we will have new report, it should be ok. |
yes, both in nmodl and coreneuron. once it is merged after the CI runs elsewhere you start seeing them. |
Co-authored-by: Omar Awile <omar.awile@gmail.com>
Co-authored-by: Omar Awile <omar.awile@gmail.com>
* Code coverage setup * Update neuron-ci.yml * Add codecov.io badge
* Code coverage setup * Update neuron-ci.yml * Add codecov.io badge
Covering C++ and Python