Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code coverage setup - codecov.io #962

Merged
merged 7 commits into from
Feb 5, 2021
Merged

code coverage setup - codecov.io #962

merged 7 commits into from
Feb 5, 2021

Conversation

alexsavulescu
Copy link
Member

Covering C++ and Python

@alexsavulescu alexsavulescu requested review from nrnhines, pramodk and ohm314 and removed request for nrnhines February 5, 2021 10:56
@alexsavulescu
Copy link
Member Author

Report here: https://codecov.io/gh/neuronsimulator/nrn/tree/54fdb229de986666e2ac3c0c2d9615c420677ecd
We're not doing that well :)

pramodk
pramodk approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexsavulescu
Copy link
Member Author

Just FYI I couldn't use pytest-cov for all our python tests because for some of them we are passing extra arguments. Will address that in future PRs (I also plan on working a bit more on testing)

ohm314
ohm314 requested changes Feb 5, 2021
View reviewed changes
Copy link
Member

@ohm314 ohm314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! I just have a few minor issues...

.github/workflows/coverage.yml Outdated Show resolved Hide resolved
.github/workflows/coverage.yml Outdated Show resolved Hide resolved
.github/workflows/coverage.yml Show resolved Hide resolved
.github/workflows/coverage.yml Show resolved Hide resolved
@ramcdougal
Copy link
Member

If you click on e.g. psection.py from https://codecov.io/gh/neuronsimulator/nrn/tree/54fdb229de986666e2ac3c0c2d9615c420677ecd/share/lib/python/neuron, you'll get an error message about needing to configure relative paths.

@alexsavulescu
Copy link
Member Author

https://codecov.io/gh/neuronsimulator/nrn/tree/54fdb229de986666e2ac3c0c2d9615c420677ecd/share/lib/python/neuron

Works for me:
https://codecov.io/gh/neuronsimulator/nrn/src/54fdb229de986666e2ac3c0c2d9615c420677ecd/share/lib/python/neuron/psection.py

Anyway, we need to have a build for master as starting base. We can check it out after we merge.

@pramodk
Copy link
Member

pramodk commented Feb 5, 2021

Anyway, we need to have a build for master as starting base. We can check it out after we merge.

We saw similar thing for coreneuron. I think after merge when we will have new report, it should be ok.

ohm314
ohm314 reviewed Feb 5, 2021
View reviewed changes
.github/workflows/coverage.yml Show resolved Hide resolved
.github/workflows/coverage.yml Show resolved Hide resolved
.github/workflows/coverage.yml Outdated Show resolved Hide resolved
@ohm314
Copy link
Member

ohm314 commented Feb 5, 2021

Anyway, we need to have a build for master as starting base. We can check it out after we merge.

We saw similar thing for coreneuron. I think after merge when we will have new report, it should be ok.

yes, both in nmodl and coreneuron. once it is merged after the CI runs elsewhere you start seeing them.

alexsavulescu and others added 2 commits February 5, 2021 20:03
@alexsavulescu @ohm314
Update .github/workflows/coverage.yml
fcfead0 
Co-authored-by: Omar Awile <omar.awile@gmail.com>
@alexsavulescu @ohm314
Update .github/workflows/coverage.yml
3dc5152 
Co-authored-by: Omar Awile <omar.awile@gmail.com>
@pramodk pramodk merged commit e82b3f5 into neuronsimulator:master Feb 5, 2021
@alexsavulescu alexsavulescu deleted the codecov-nrn branch February 5, 2021 21:38
@olupton olupton mentioned this pull request Feb 8, 2021
Merged
alexsavulescu added a commit that referenced this pull request Apr 13, 2021
@alexsavulescu
Code coverage setup - codecov.io (#962)
f1ed21c 
* Code coverage setup
* Update neuron-ci.yml
* Add codecov.io badge
@alexsavulescu alexsavulescu mentioned this pull request Apr 26, 2021
Closed
alexsavulescu added a commit that referenced this pull request Apr 30, 2021
@alexsavulescu
Code coverage setup - codecov.io (#962)
86eff6b 
* Code coverage setup
* Update neuron-ci.yml
* Add codecov.io badge
@alexsavulescu alexsavulescu mentioned this pull request Mar 22, 2022
Closed
15 tasks
olupton pushed a commit that referenced this pull request Dec 7, 2022
@alkino
Remove CUDA accelerator (#962)
a1412c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohm314 ohm314 ohm314 approved these changes

@pramodk pramodk pramodk approved these changes

@nrnhines nrnhines nrnhines approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexsavulescu @ramcdougal @pramodk @ohm314 @nrnhines