Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] _interpolate_big method from signal_fixpeaks method #530

Merged

Conversation

pfilo8
Copy link
Contributor

@pfilo8 pfilo8 commented Sep 2, 2021

Description

This PR aims at repairing a possible bug in the _interpolate_big method from the signal_fixpeaks method, i.e. wrong argument is passed to the interpolate function.

Proposed Changes

One-line change which is self-explanatory.

Checklist

Here are some things to check before creating the PR. If you encounter any issues, do let us know :)

  • [ x] I have read the CONTRIBUTING file.
  • [ x] My PR is targetted at the dev branch (and not towards the master branch).
  • [ x] I ran the CODE CHECKS on the files I added or modified and fixed the errors.
  • [ x] I have added the newly added features to News.rst (if applicable)

@welcome
Copy link

welcome bot commented Sep 2, 2021

Thanks for opening this pull request! We'll make sure it's perfect before merging 🤗 force
Make sure to read the contributing guide. Also, if you think that your contribution is worthy of it, you can consider adding yourself to the Contributors list (feel free to ask us if you have any doubts).

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2021

Codecov Report

Merging #530 (fbbae53) into dev (c110438) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #530   +/-   ##
=======================================
  Coverage   85.31%   85.31%           
=======================================
  Files         199      199           
  Lines        9750     9772   +22     
=======================================
+ Hits         8318     8337   +19     
- Misses       1432     1435    +3     
Impacted Files Coverage Δ
neurokit2/signal/signal_fixpeaks.py 97.70% <0.00%> (ø)
neurokit2/rsp/rsp_simulate.py 95.53% <0.00%> (-2.68%) ⬇️
neurokit2/complexity/entropy_multiscale.py 94.23% <0.00%> (-1.12%) ⬇️
neurokit2/complexity/fractal_katz.py 100.00% <0.00%> (ø)
neurokit2/complexity/entropy_fuzzy.py 100.00% <0.00%> (ø)
neurokit2/complexity/entropy_sample.py 100.00% <0.00%> (ø)
neurokit2/complexity/entropy_shannon.py 100.00% <0.00%> (ø)
neurokit2/complexity/fractal_higuchi.py 94.89% <0.00%> (+0.05%) ⬆️
neurokit2/emg/emg_activation.py 87.32% <0.00%> (+0.08%) ⬆️
neurokit2/complexity/fractal_dfa.py 93.33% <0.00%> (+0.09%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c110438...fbbae53. Read the comment docs.

@DominiqueMakowski
Copy link
Member

Siemanko @pfilo8

good catch! looks great

dzienki za ta contribucje ☺️

@DominiqueMakowski DominiqueMakowski merged commit 9bf9532 into neuropsychology:dev Sep 3, 2021
@welcome
Copy link

welcome bot commented Sep 3, 2021

landing
Congrats on merging your first pull request! 🎉🍾 We're looking forward to your next one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants