Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Signal_fixpeaks_neurokit #538

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

pfilo8
Copy link
Contributor

@pfilo8 pfilo8 commented Sep 6, 2021

This PR aims at repairing a possible bug in the _signal_fixpeaks_neurokit method from the signal_fixpeaks method, i.e., the wrong argument is passed to the _interpolate_big function.

Another night - another catch!

Proposed Changes

One-line change which is self-explanatory.

Checklist

Here are some things to check before creating the PR. If you encounter any issues, do let us know :)

  • I have read the CONTRIBUTING file.
  • My PR is targetted at the dev branch (and not towards the master branch).
  • I ran the CODE CHECKS on the files I added or modified and fixed the errors.
  • I have added the newly added features to News.rst (if applicable)

@welcome
Copy link

welcome bot commented Sep 6, 2021

Thanks for opening this pull request! We'll make sure it's perfect before merging 🤗 force
Make sure to read the contributing guide. Also, if you think that your contribution is worthy of it, you can consider adding yourself to the Contributors list (feel free to ask us if you have any doubts).

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2021

Codecov Report

Merging #538 (acc2ecc) into dev (c110438) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #538      +/-   ##
==========================================
+ Coverage   85.31%   85.37%   +0.06%     
==========================================
  Files         199      199              
  Lines        9750     9772      +22     
==========================================
+ Hits         8318     8343      +25     
+ Misses       1432     1429       -3     
Impacted Files Coverage Δ
neurokit2/signal/signal_fixpeaks.py 97.70% <100.00%> (ø)
neurokit2/complexity/entropy_multiscale.py 94.23% <0.00%> (-1.12%) ⬇️
neurokit2/complexity/fractal_katz.py 100.00% <0.00%> (ø)
neurokit2/complexity/entropy_fuzzy.py 100.00% <0.00%> (ø)
neurokit2/complexity/entropy_sample.py 100.00% <0.00%> (ø)
neurokit2/complexity/entropy_shannon.py 100.00% <0.00%> (ø)
neurokit2/complexity/fractal_higuchi.py 94.89% <0.00%> (+0.05%) ⬆️
neurokit2/emg/emg_activation.py 87.32% <0.00%> (+0.08%) ⬆️
neurokit2/complexity/fractal_dfa.py 93.33% <0.00%> (+0.09%) ⬆️
neurokit2/complexity/complexity_lempelziv.py 95.34% <0.00%> (+0.11%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c110438...acc2ecc. Read the comment docs.

@DominiqueMakowski
Copy link
Member

Awesome, thanks again! feel free to add yourself to the contributors list :)

pfilo8 added a commit to pfilo8/NeuroKit that referenced this pull request Sep 6, 2021
As allowed in this PR :)
neuropsychology#538
@pfilo8 pfilo8 mentioned this pull request Sep 6, 2021
4 tasks
@DominiqueMakowski DominiqueMakowski merged commit 91d69ef into neuropsychology:dev Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants