-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complexity hotfixes #567
Complexity hotfixes #567
Conversation
import neurokit2 as nk
signal = nk.signal_simulate(duration=2, sampling_rate=200, frequency=[5, 6], noise=0.5)
mplzc, info = nk.complexity_lempelziv(signal, delay=7, dimension=3, multiscale=True, show=True) MPLZC fails as soon as delay get more than like 1 or 2 🤔 |
That's because for the final scale factor, the length of the coarse-grained signal (which depends on dimension and the scale factors we use) cannot be shorter than 2 times the delay (so for the above example the final coarsegrained signal has a length of 12 data samples and embedding delay of lower than 12 / 2 = 6 is needed and hence On a related note, I found the reviewers report to the original MPLZC paper here. This is the author's response to the reviewers' comments regarding how the role of tau is unclear in the paper:
|
should we use always delay=1 when coarsegraining? |
Yes perhaps we should emphasize in our docstrings to use |
for the other multiscale measures it just hardcodes delay=1 when doing the coarsegraining (overwriting in the process any other value) we should probably just do the same right? |
ah yes you're right let's hardcode it then! testing of different delays can be considered further down the road (including exposing a |
No description provided.