-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
find_best_model issues #80
Comments
@HugoNjb Awesome! Let me know if you have any trouble with github 😄 I'll look into the third issue Thanks for your help! |
I sadly didn't find a way to push the script. Could you help me on it ? You're welcome ! 👍 |
@HugoNjb Github is a total headache at the beginning, but it's worth to persevere. I believe there are ways different of doing this, but here's one possibility:
Hope that's helpful ^^ |
See issue neuropsychology#80 (find_best_model issues)
I think I did it right ! |
@HugoNjb I don't have any PR here right now, I believe you only created the branch in your fork. Try going here and creating a pull request from |
Hey, thanks again for your commit. If you install the dev branch Let me know! |
I tested it, and everything seems to work just fine. Thanks again for the great responses and reactivity ! |
Dear Dominique,
Thank you very much for your package, I think it will be very useful to me in the future.
I am notably interested in the find_best_model function and I encontered the following bugs while exploring it.
1
find_best_model.stanreg gives the following error message when a random intercept is entered in the formula :
Solution
It seems to come from the loo function of the rstanarm package. I added the following lines into find_best_model.stanreg to temporarily solve the problem :
2
Inside find_best_model.stanreg, warning messages are sent when accessing the loos estimates :
Solution
I replaced them with those lines:
3
The find_best_model works for merModLmerTest class used in the lmerTest v2.0-36 package but not for lmerModLmerTest class used in lmerTest v3.0.
Solution
From what I understood, the problem seems to come from the find_combinations.formula function. However, I don't know how to simply resolve this problem.
I am new to github and I will try to push my find_best_model.stanreg enhancement in the dev branch immediately.
Thanks in advance !
The text was updated successfully, but these errors were encountered: