Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set resolver to dockers internal dns for first 30 seconds #1002

Merged
merged 4 commits into from Feb 1, 2022

Conversation

rwblair
Copy link
Collaborator

@rwblair rwblair commented Oct 28, 2021

If the swagger containers hostname wouldn't resolve nginx would fail to start. I put in the set directive by its proxypass to get around nginx trying to do the hostname lookup on startup. Nginx was complaining about not having a resolver when you visited /api/swagger. Made change according to this:

https://sandro-keil.de/blog/let-nginx-start-if-upstream-host-is-unavailable-or-down/

@rwblair
Copy link
Collaborator Author

rwblair commented Oct 28, 2021

neuroscout/pyNS#97

@codecov-commenter
Copy link

Codecov Report

Merging #1002 (59f8815) into master (6753406) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1002   +/-   ##
=======================================
  Coverage   78.34%   78.34%           
=======================================
  Files          63       63           
  Lines        3247     3247           
=======================================
  Hits         2544     2544           
  Misses        703      703           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6753406...59f8815. Read the comment docs.

@cypress
Copy link

cypress bot commented Oct 28, 2021



Test summary

6 1 0 0Flakiness 0


Run details

Project Neuroscout
Status Failed
Commit 1ad6102 ℹ️
Started Oct 29, 2021 7:49 PM
Ended Oct 29, 2021 7:51 PM
Duration 01:56 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️


Failures

cypress/integration/analysis_builder.spec.js Failed
1 Analysis Builder > analysis builder

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@rwblair
Copy link
Collaborator Author

rwblair commented Oct 28, 2021

Pushed to deepdream, no longer getting 502 error, But there is something else wrong now, swagger ui is blank with lots of JS errors like:

Uncaught ReferenceError: SwaggerUIBundle is not defined

@adelavega
Copy link
Collaborator

@rwblair I think theres' something wrong w/ nginx bc it doesn't seem to be loading the json files and css files for swagger ui.

looks like maybe they're routed instead to the wrong container (neuroscout?). can you take a look?

@adelavega
Copy link
Collaborator

^~ vs ^ vs none? otherwise let's merge this so it fixes swagger-ui and we can fix the problem of restarting nginx (when swagger fails) in another PR later.

@adelavega adelavega merged commit d8acab4 into master Feb 1, 2022
@adelavega adelavega deleted the nginx_resolver branch September 22, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants