New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tour #1049
Conversation
Because of how steps is conditionally defined by pathname there is a bug if you go through the tour into the builder section, then close the tour, then restart it via the drop down, current step will be greater than 3 but the steps array is only 4 long when pathname is builder. Need to reset step count on reopen tour, or not redirect to home on starting it. |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Awesome, can you deploy to DD? |
Codecov Report
@@ Coverage Diff @@
## master #1049 +/- ##
=======================================
Coverage 78.23% 78.23%
=======================================
Files 63 63
Lines 3272 3272
=======================================
Hits 2560 2560
Misses 712 712 Continue to review full report at Codecov.
|
@adelavega should be up on deepdream |
Reminder: only changes needed are fixing tests, and changing the color of the flashy tour button. |
Not sure why withRouter broke, but I updated Tour to be a proper component wrapped in withRouter and added typing information as necessary.