Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google colab link + remove submission modal #1061

Merged
merged 14 commits into from Jun 3, 2022
Merged

Conversation

rwblair
Copy link
Collaborator

@rwblair rwblair commented Jun 1, 2022

fixes #1056 fixes #1052

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2022

Codecov Report

Merging #1061 (f282cf8) into master (bf3b4ed) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1061   +/-   ##
=======================================
  Coverage   78.23%   78.24%           
=======================================
  Files          63       63           
  Lines        3272     3273    +1     
=======================================
+ Hits         2560     2561    +1     
  Misses        712      712           
Impacted Files Coverage Δ
neuroscout/models/task.py 96.29% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf3b4ed...f282cf8. Read the comment docs.

@cypress
Copy link

cypress bot commented Jun 1, 2022



Test summary

7 1 0 0Flakiness 1


Run details

Project Neuroscout
Status Failed
Commit 978ccc5 ℹ️
Started Jun 3, 2022 8:49 PM
Ended Jun 3, 2022 8:52 PM
Duration 02:28 💡
OS Linux Ubuntu - 20.04
Browser Electron 94

View run in Cypress Dashboard ➡️


Failures

cypress/integration/analysis_builder.spec.js Failed
1 Analysis Builder > analysis builder

Flakiness

cypress/integration/home_spec.js Flakiness
1 The Home Page > navigation bar contents

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@adelavega
Copy link
Collaborator

Looks good! Can you make the link open in a new window?

@rwblair
Copy link
Collaborator Author

rwblair commented Jun 3, 2022

Double checked cypress tests work fine not in CI.

@rwblair rwblair merged commit a8e55ee into master Jun 3, 2022
@adelavega adelavega deleted the google_colab_link branch September 22, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make submitting analysis less scary Add link to Google Colab in Run
3 participants