New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build and push step to GH Actions #1083
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1083 +/- ##
=======================================
Coverage 78.21% 78.21%
=======================================
Files 63 63
Lines 3269 3269
=======================================
Hits 2557 2557
Misses 712 712
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
I think I'll leave tests as is, as its much faster to run tests without building the entire image |
The one issue is these don't take variables.
For now we can test this working in STAGING by pushing by the user to the server. If this works, we can then add a way to trigger GH Action to push to staging given some tag. If that all works, we can then set up this working on production. |
Makes changes to verify we can rebuild the image, and make it easier to deploy pre-built images.
docker-compose.yml
file such that it pulls from GHCR, and can be specified to be a pr, release version or master.To-Do (not necessarily in this PR)
I attempted this but it became complicated because of
docker-compose
. I think a good setup would be one job for image build + push (without needing to pass tests for PRs) and in parallel adocker-compose
build and test, like is done inneurostore
.Otherwise, I think integrating pushing to GHCR and using that image with
docker-compose
is not clear to me.(Note: It may be possible if we add a custom GHA only .yml which pulls the pre-loaded image, that would have a different name)