Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Production docker build #1091

Merged
merged 12 commits into from Nov 4, 2022
Merged

Fix Production docker build #1091

merged 12 commits into from Nov 4, 2022

Conversation

adelavega
Copy link
Collaborator

@adelavega adelavega commented Nov 3, 2022

  • Fixing production build (i.e. prod), which should load everything from image including pre-build front end
  • Moved all files to /usr/src/app except for mapped config file app.py
  • Frontend config file (config.ts.prod) is preloaded into image
  • Shared volume in prod makes static files from pre-built neuroscout image available to nginx

For non production environments the following volume is mapped:

-./neuroscout:/usr/src/app/neuroscout

This is dropped in the production environment, so that all files are pre-loaded

Warning: pip install -e will fail, because it tries to install in a directory that is later copied over /usr/src/app

@codecov-commenter
Copy link

Codecov Report

Merging #1091 (fed8fde) into master (3d5a010) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1091   +/-   ##
=======================================
  Coverage   78.76%   78.76%           
=======================================
  Files          61       61           
  Lines        3169     3169           
=======================================
  Hits         2496     2496           
  Misses        673      673           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cypress
Copy link

cypress bot commented Nov 3, 2022



Test summary

8 0 0 0Flakiness 0


Run details

Project Neuroscout
Status Passed
Commit 563e0b8 ℹ️
Started Nov 3, 2022 10:13 PM
Ended Nov 3, 2022 10:14 PM
Duration 00:48 💡
OS Linux Ubuntu - 20.04
Browser Electron 102

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@adelavega adelavega merged commit 738042e into master Nov 4, 2022
@adelavega adelavega deleted the fix/prod branch November 4, 2022 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants