Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Datalad installation path #1107

Merged
merged 2 commits into from Jul 1, 2023
Merged

FIX: Datalad installation path #1107

merged 2 commits into from Jul 1, 2023

Conversation

adelavega
Copy link
Collaborator

@adelavega adelavega commented Jun 30, 2023

  • Also fix frontend test config

@codecov-commenter
Copy link

Codecov Report

Merging #1107 (6755bb4) into master (926031c) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #1107   +/-   ##
=======================================
  Coverage   76.69%   76.69%           
=======================================
  Files          64       64           
  Lines        3334     3334           
=======================================
  Hits         2557     2557           
  Misses        777      777           
Impacted Files Coverage Δ
neuroscout/populate/setup.py 42.60% <100.00%> (ø)

@cypress
Copy link

cypress bot commented Jun 30, 2023

8 failed tests on run #709 ↗︎

8 0 0 0 Flakiness 0

Details:

Merge 5d2b377 into 926031c...
Project: Neuroscout Commit: 88575825fc ℹ️
Status: Failed Duration: 07:16 💡
Started: Jun 30, 2023 10:25 PM Ended: Jun 30, 2023 10:32 PM
Failed  analysis_builder.spec.js • 2 failed tests

View Output Video

Test Artifacts
Analysis Builder > analysis builder Output Screenshots Video
Analysis Builder > opens tour Output Screenshots Video
Failed  home_spec.js • 6 failed tests

View Output Video

Test Artifacts
The Home Page > successfully loads Screenshots Video
The Home Page > navigation bar contents Screenshots Video
The Home Page > splash page contents Screenshots Video
The Home Page > test sign up button 1 Screenshots Video
The Home Page > test sign up button 2 Screenshots Video
The Home Page > test sign in button Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@adelavega
Copy link
Collaborator Author

Frontend tests are still failing but I'll leave that for another PR

@adelavega adelavega closed this Jul 1, 2023
@adelavega adelavega reopened this Jul 1, 2023
@adelavega adelavega merged commit b46cfe6 into master Jul 1, 2023
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants