Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dataset resources, and task description #372

Merged
merged 14 commits into from Sep 19, 2018
Merged

Add dataset resources, and task description #372

merged 14 commits into from Sep 19, 2018

Conversation

adelavega
Copy link
Collaborator

@adelavega adelavega commented Sep 14, 2018

Addresses #343
Instead of repeating dataset description, added a hand annotation for task "summary"

@adelavega
Copy link
Collaborator Author

Hey @rwblair, could you update the frontend to show summary for Task "description". And add a small column on the right for each Dataset that is a link to the url property? Feel free to push to this PR.

@adelavega
Copy link
Collaborator Author

adelavega commented Sep 14, 2018

Also note that the database needs to manually updated to have those values (although upon fresh ingestion, they would be there). Once this is ready for testing on staging, I'll have to update the main db to add those values as well...

@rwblair
Copy link
Collaborator

rwblair commented Sep 17, 2018

The URL column is a bit cramped with all the other fields on the dataset table. Push with it in place so you can see it as is. Width is hard set and should probably be increased.

Another option might be to have the name of the dataset be a link to the URL.

@codecov-io
Copy link

Codecov Report

Merging #372 into master will increase coverage by 0.29%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #372      +/-   ##
==========================================
+ Coverage   84.95%   85.25%   +0.29%     
==========================================
  Files          37       37              
  Lines        1476     1519      +43     
==========================================
+ Hits         1254     1295      +41     
- Misses        222      224       +2
Impacted Files Coverage Δ
neuroscout/populate/json.py 95.77% <ø> (ø) ⬆️
neuroscout/resources/task.py 100% <100%> (ø) ⬆️
neuroscout/populate/ingest.py 91.42% <100%> (+0.06%) ⬆️
neuroscout/models/dataset.py 95.45% <100%> (+0.21%) ⬆️
neuroscout/resources/dataset.py 100% <100%> (ø) ⬆️
neuroscout/models/task.py 93.75% <100%> (+0.41%) ⬆️
neuroscout/resources/run.py 100% <100%> (ø) ⬆️
neuroscout/populate/annotate.py 91.45% <0%> (+1.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4027a0...ea80614. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #372 into master will increase coverage by 0.29%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #372      +/-   ##
==========================================
+ Coverage   84.95%   85.25%   +0.29%     
==========================================
  Files          37       37              
  Lines        1476     1519      +43     
==========================================
+ Hits         1254     1295      +41     
- Misses        222      224       +2
Impacted Files Coverage Δ
neuroscout/populate/json.py 95.77% <ø> (ø) ⬆️
neuroscout/resources/task.py 100% <100%> (ø) ⬆️
neuroscout/populate/ingest.py 91.42% <100%> (+0.06%) ⬆️
neuroscout/models/dataset.py 95.45% <100%> (+0.21%) ⬆️
neuroscout/resources/dataset.py 100% <100%> (ø) ⬆️
neuroscout/models/task.py 93.75% <100%> (+0.41%) ⬆️
neuroscout/resources/run.py 100% <100%> (ø) ⬆️
neuroscout/populate/annotate.py 91.45% <0%> (+1.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4027a0...ea80614. Read the comment docs.

@adelavega adelavega merged commit 893cb73 into master Sep 19, 2018
@adelavega adelavega deleted the description branch September 19, 2018 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants