Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only create Predictors for EFs present in 90% of runs #542

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Conversation

adelavega
Copy link
Collaborator

Closes #541

I decided on a 90% default

That code in general is not the most efficient and a bit hard to debug, but I can't think of a much better way to do it for now.

At least this will speed things up by only processing useful Features (i.e. those in most runs).

@codecov-io
Copy link

codecov-io commented Apr 17, 2019

Codecov Report

Merging #542 into master will decrease coverage by 2.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #542      +/-   ##
==========================================
- Coverage    85.4%   83.32%   -2.08%     
==========================================
  Files          47       38       -9     
  Lines        2281     1649     -632     
==========================================
- Hits         1948     1374     -574     
+ Misses        333      275      -58
Impacted Files Coverage Δ
neuroscout/populate/extract.py 97.75% <100%> (+0.07%) ⬆️
neuroscout/tests/request_utils.py
neuroscout/tests/api/test_dataset.py
neuroscout/tests/api/test_user.py
neuroscout/tests/api/test_predictor.py
neuroscout/tests/test_views.py
neuroscout/tests/api/test_analyses.py
neuroscout/tests/test_models.py
neuroscout/tests/conftest.py
neuroscout/tests/api/test_run_task.py
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b013bf...17842a4. Read the comment docs.

@adelavega
Copy link
Collaborator Author

This seems to be working well

@adelavega adelavega merged commit 6b54395 into master Apr 19, 2019
@adelavega adelavega deleted the all_runs branch April 19, 2019 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable Predictors not present across all runs by default
2 participants