[WIP] Link to neurovault uploads.

[rwblair]

Currently will only display latest failed attempt with traceback, and will only show latest pending attempt with traceback if there are no successes. All success shown if available. Not sure how to word the failed and pending titles.

API endpoint currently only hit on initial analysis load and when the analysisId changes.

[codecov-io]

Codecov Report

Merging #584 into master will decrease coverage by 4.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #584      +/-   ##
==========================================
- Coverage    76.5%   72.38%   -4.13%     
==========================================
  Files          62       53       -9     
  Lines        2733     2053     -680     
==========================================
- Hits         2091     1486     -605     
+ Misses        642      567      -75

Impacted Files	Coverage Δ
neuroscout/tests/request_utils.py
neuroscout/tests/api/test_dataset.py
neuroscout/tests/api/test_user.py
neuroscout/tests/api/test_predictor.py
neuroscout/tests/test_views.py
neuroscout/tests/api/test_analyses.py
neuroscout/tests/test_models.py
neuroscout/tests/conftest.py
neuroscout/tests/api/test_run_task.py

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fefcb49...f123612. Read the comment docs.

[adelavega]

Nice! Thanks! This looks great. I may push a change with minor aesthetic tweaks but otherwise I think this is what we need.

Question: what do you mean by:

API endpoint currently only hit on initial analysis load and when the analysisId changes.

What if you're looking at Status and then an upload gets pushed. Maybe we can have a little "refresh" icon? Or I guess it's probably reasonable for people to expect to have to refresh the page to get the latest?

[adelavega]

Minor (more of a note to self): Let's format this timestamp nicer Uploaded at: 2019-05-27T19:03:00

[adelavega]

If there is nothing to show, either have a place holder below "NeuroVault Uploads", or don't show. The latter is probably best, especially if it hasn't been compiled yet. Maybe after compilation it can have a place holder

[rwblair]

Unfortunately Date.parse in the app wasn't able to parse '2019-05-27T19:03:00' (though my local node install was). Need to find another way of parsing (or can start just replace that inner T with a space? or remove the time part all together?)

[adelavega]

Replacing T with a space should be fine, I think!

…

On Wed, Jun 5, 2019, 12:28 AM Ross Blair ***@***.***> wrote: Unfortunately Date.parse in the app wasn't able to parse '2019-05-27T19:03:00' (though my local node install was). Need to find another way of parsing (or can start just replace that inner T with a space? or remove the time part all together?) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#584?email_source=notifications&email_token=AAVFLMB6YLDSNFPCJCDB5ODPY3UCLA5CNFSM4HSDYFN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW6BWAI#issuecomment-498866945>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVFLMDD5CM7SVKA5WSQWDDPY3UCLANCNFSM4HSDYFNQ> .

[adelavega]

Is this still WIP? Looks pretty good to me.

[adelavega]

I'm going to merge, it looks good to me