Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to convolve all non fmriprep predictors. #588

Merged

Conversation

rwblair
Copy link
Collaborator

@rwblair rwblair commented Jun 5, 2019

Also when loading an existing analysis enable all tabs if any contrasts have been made.

@codecov-io
Copy link

Codecov Report

Merging #588 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #588   +/-   ##
=======================================
  Coverage   72.38%   72.38%           
=======================================
  Files          53       53           
  Lines        2053     2053           
=======================================
  Hits         1486     1486           
  Misses        567      567

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24b801b...bf99414. Read the comment docs.

@adelavega
Copy link
Collaborator

Looks pretty good but I need to run the wording by @tal

@tal
Copy link

tal commented Jun 6, 2019

I assume you want someone else

@rwblair
Copy link
Collaborator Author

rwblair commented Jun 6, 2019

Sorry about that @tal. paging @tyarkoni instead.

Current wording of the button is "Select All Non-Confounds"

@adelavega
Copy link
Collaborator

LGTM Merging

@adelavega adelavega merged commit dfe736c into neuroscout:master Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants