Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analytics, reorg front end code #616

Merged
merged 23 commits into from Jul 12, 2019
Merged

Conversation

rwblair
Copy link
Collaborator

@rwblair rwblair commented Jul 10, 2019

Lot of things got moved around. Need to test some more to be certain everything actually works as expected.

@codecov-io
Copy link

codecov-io commented Jul 10, 2019

Codecov Report

Merging #616 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #616   +/-   ##
=======================================
  Coverage   70.79%   70.79%           
=======================================
  Files          56       56           
  Lines        2164     2164           
=======================================
  Hits         1532     1532           
  Misses        632      632

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 302b37f...f035b20. Read the comment docs.

@rwblair rwblair changed the title [WIP] Add analytics, reorg front end code Add analytics, reorg front end code Jul 11, 2019
@rwblair
Copy link
Collaborator Author

rwblair commented Jul 11, 2019

@adelavega Heads up I was running into performance issues with the react debugger running in firefox with large numbers of predictors. Let me know if you notice any other wonky performance issues.

Also need to add a 'ga_key': 'UA-whatvever' to the config.ts for analytics to work. I've been seeing my computer come up in the dashboard when using the sites.

@rwblair
Copy link
Collaborator Author

rwblair commented Jul 11, 2019

Spent some time this morning profiling the site, the slowness with selecting/unselecting elements on a long list of predictors can't really be avoided. It does re render each line in the table, which only takes a few ms per row, but at a max of 200 rows it adds up.

Not for this PR, but what do we think about putting each category of predictor into its own table that starts out collapsed?

@rwblair
Copy link
Collaborator Author

rwblair commented Jul 11, 2019

fixes #612 #610 and #569

@adelavega adelavega merged commit a99c69b into neuroscout:master Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants