Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create predictor collection #628

Merged
merged 4 commits into from Aug 1, 2019
Merged

Fix create predictor collection #628

merged 4 commits into from Aug 1, 2019

Conversation

adelavega
Copy link
Collaborator

@adelavega adelavega commented Jul 31, 2019

Predictors were not being generated correctly (looping was done wrong, and nans were not skipped) This should fix that.

@codecov-io
Copy link

codecov-io commented Jul 31, 2019

Codecov Report

Merging #628 into master will decrease coverage by 0.02%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #628      +/-   ##
==========================================
- Coverage   82.33%   82.31%   -0.03%     
==========================================
  Files          56       57       +1     
  Lines        2174     2177       +3     
==========================================
+ Hits         1790     1792       +2     
- Misses        384      385       +1
Impacted Files Coverage Δ
celery_worker/app.py 0% <ø> (ø) ⬆️
neuroscout/resources/analysis/reports.py 63.41% <ø> (ø) ⬆️
celery_worker/tasks.py 0% <0%> (ø)
neuroscout/core.py 67.74% <100%> (ø) ⬆️
neuroscout/tasks/upload.py 55.71% <64.28%> (+1.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9fd912...9f2904b. Read the comment docs.

@adelavega adelavega merged commit ca16f2b into master Aug 1, 2019
@adelavega adelavega deleted the fix/upload branch August 1, 2019 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants