Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update neurovault upload status component/api calls #669

Merged
merged 4 commits into from Oct 3, 2019

Conversation

rwblair
Copy link
Collaborator

@rwblair rwblair commented Oct 3, 2019

fixes #652

@rwblair
Copy link
Collaborator Author

rwblair commented Oct 3, 2019

There is an assumption right now that there will always be a collection_id returned from the api.

@codecov-io
Copy link

codecov-io commented Oct 3, 2019

Codecov Report

Merging #669 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #669      +/-   ##
==========================================
- Coverage   81.81%   81.76%   -0.06%     
==========================================
  Files          57       57              
  Lines        2233     2270      +37     
==========================================
+ Hits         1827     1856      +29     
- Misses        406      414       +8
Impacted Files Coverage Δ
neuroscout/tasks/report.py 75% <0%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 726368d...953abc3. Read the comment docs.

@adelavega adelavega self-requested a review October 3, 2019 20:24
Copy link
Collaborator

@adelavega adelavega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good. The only comment is that change the following text:

uploads failed/succeeded -> "image uploads"

Also, do you think we should allow users to see why some files failed? Or would it be to verbose?

@adelavega
Copy link
Collaborator

Another minor comment: Instead of putting the box header to be the URL, make it "Collection ID: {id}" with the link staying the same

@rwblair rwblair requested a review from adelavega October 3, 2019 21:17
@adelavega adelavega merged commit 7002acb into master Oct 3, 2019
@adelavega adelavega deleted the 652_neurovault_upload_status branch October 3, 2019 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update frontend to look at NV file status
3 participants