Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sentry to front end and backend. #672

Merged
merged 6 commits into from Oct 17, 2019
Merged

Add sentry to front end and backend. #672

merged 6 commits into from Oct 17, 2019

Conversation

rwblair
Copy link
Collaborator

@rwblair rwblair commented Oct 10, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 10, 2019

Codecov Report

Merging #672 into master will decrease coverage by 0.18%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #672      +/-   ##
==========================================
- Coverage   81.81%   81.62%   -0.19%     
==========================================
  Files          57       57              
  Lines        2233     2259      +26     
==========================================
+ Hits         1827     1844      +17     
- Misses        406      415       +9
Impacted Files Coverage Δ
neuroscout/config/example_app.py 0% <0%> (ø) ⬆️
celery_worker/app.py 0% <0%> (ø) ⬆️
neuroscout/basic.py 89.47% <85.71%> (-3.39%) ⬇️
neuroscout/models/dataset.py 92.3% <0%> (-3.15%) ⬇️
neuroscout/populate/ingest.py 91.72% <0%> (-0.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df763f6...75c2b0c. Read the comment docs.

@adelavega
Copy link
Collaborator

I wonder if we should add sentry to the celery worker. Seems like a good idea actually.

@adelavega adelavega merged commit 37ed784 into master Oct 17, 2019
@adelavega adelavega deleted the add_sentry_frontend branch October 17, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants