Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sherlock Merlin #675

Merged
merged 2 commits into from Oct 15, 2019
Merged

Update Sherlock Merlin #675

merged 2 commits into from Oct 15, 2019

Conversation

adelavega
Copy link
Collaborator

Re-enable and update the Sherlock Merlin dataset.

  • Fixes bug related to pybids > 0.8. layout.get_collections would return incorrect result because preproc and raw file interfered in variable loading.
  • Ensure re ingesting does not cause conflict with old RunStimulus

@adelavega
Copy link
Collaborator Author

adelavega commented Oct 14, 2019

TODO:

  • Catch up Sherlock Merlin on extracted variables
  • fmriprep failed on confounds

@codecov-io
Copy link

codecov-io commented Oct 14, 2019

Codecov Report

Merging #675 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #675      +/-   ##
==========================================
+ Coverage   81.81%   81.83%   +0.01%     
==========================================
  Files          57       57              
  Lines        2233     2235       +2     
==========================================
+ Hits         1827     1829       +2     
  Misses        406      406
Impacted Files Coverage Δ
neuroscout/populate/ingest.py 92.59% <100%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e60977f...9d766bd. Read the comment docs.

@adelavega adelavega merged commit 73ce2c2 into master Oct 15, 2019
@adelavega adelavega deleted the add/sherlock_merlin branch January 15, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants