Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance report plots #682

Merged
merged 4 commits into from Oct 23, 2019
Merged

Enhance report plots #682

merged 4 commits into from Oct 23, 2019

Conversation

adelavega
Copy link
Collaborator

Closes #679
Turns out that making SVGs and PNGs with Altair is a pain, because we need to install Firefox or Chrome + Selenium. This is doable, but would require re-doing the way our Dockerfile is set up, as installing these has failed so far.

Instead, I made some updates to the aesthetic, making it easier to interact. I think by removing the "interactive" from the top part, and making the legend easier to click on, the plots are more responsive.

I think to deal w/ performance issues in #533 we can either close unused components (and even re-fetch the report), or only allow a single report to be shown at once.

Even then, for very large designs this may be an issue but we can deal with that when it happens.

@adelavega adelavega merged commit d9bce50 into master Oct 23, 2019
@adelavega adelavega deleted the split-report branch October 23, 2019 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate design matrices for effiency
1 participant