Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fixes to docs #703

Merged
merged 5 commits into from Dec 13, 2019
Merged

small fixes to docs #703

merged 5 commits into from Dec 13, 2019

Conversation

rbroc
Copy link
Collaborator

@rbroc rbroc commented Dec 11, 2019

fixed typo in dataset description and added note on absolute paths needed to run analyses via neuroscout-cli.

@rbroc
Copy link
Collaborator Author

rbroc commented Dec 11, 2019

More potential edits:

  • Add more details on sparse/dense feature representations?
  • Add more details on how data are preprocessed
  • Add overview of which features are available for each dataset/modality
  • Add more details on na replacement during transformation (why/when to replace NAs before rather then after when rescaling)
  • Potentially more info on terminology ("task", "run", "condition")
  • More info on stats behind model estimation (e.g. the concept of "fixed effects meta-analysis" at the subject level? Maybe this details can be included in the paper though)
  • Potentially add details on relevant Docker commands and flags in Run analysis section

@codecov-io
Copy link

codecov-io commented Dec 11, 2019

Codecov Report

Merging #703 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #703   +/-   ##
=======================================
  Coverage   85.67%   85.67%           
=======================================
  Files          66       66           
  Lines        2932     2932           
=======================================
  Hits         2512     2512           
  Misses        420      420

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8207a4d...9421e5c. Read the comment docs.

@adelavega adelavega merged commit 697f71a into neuroscout:master Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants