Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force reconstruct of review tab for fresh results on model change #712

Merged
merged 1 commit into from Dec 20, 2019

Conversation

rwblair
Copy link
Collaborator

@rwblair rwblair commented Dec 20, 2019

This is inefficient, every time the review tab is navigated to it hits the api to redownload results.

Before I had the conditional around the reports tab in builder the report state would properly update with the new reports as necessary but the default active plot in the plots tabs would not rerender with the new results.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@76fdc1f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #712   +/-   ##
=========================================
  Coverage          ?   85.66%           
=========================================
  Files             ?       66           
  Lines             ?     2936           
  Branches          ?        0           
=========================================
  Hits              ?     2515           
  Misses            ?      421           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76fdc1f...bc14ed8. Read the comment docs.

@adelavega
Copy link
Collaborator

LGTM, the lag is not really noticable. If it becomes an issue we can store the old state somewhere else so it doesn't have to do an HTTP request. This might be more of an issue with slow connections but I think it's fine for now.

@adelavega adelavega merged commit fffcf78 into master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants