Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore predictor-events route, dumps extracted events #720

Merged
merged 2 commits into from Jan 15, 2020
Merged

Conversation

adelavega
Copy link
Collaborator

Closes #706

This generalized the logic used in tasks.io to dump PredictorEvents even for ExtractedEvents. It creates PredictorEvents on the fly when necessary. Otherwise, it uses fast dumping for regular PredictorEvents.

Same function is used for dumping events in celery/tasks.

@codecov-io
Copy link

Codecov Report

Merging #720 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #720      +/-   ##
=========================================
+ Coverage   85.66%   85.8%   +0.14%     
=========================================
  Files          66      66              
  Lines        2936    2965      +29     
=========================================
+ Hits         2515    2544      +29     
  Misses        421     421
Impacted Files Coverage Δ
neuroscout/core.py 67.74% <ø> (ø) ⬆️
neuroscout/resources/__init__.py 100% <ø> (ø) ⬆️
neuroscout/resources/predictor.py 88.88% <100%> (+1.21%) ⬆️
neuroscout/tasks/utils/io.py 96.22% <100%> (-1.04%) ⬇️
neuroscout/utils/db.py 93.22% <100%> (+4.64%) ⬆️
neuroscout/schemas/predictor.py 100% <100%> (ø) ⬆️
neuroscout/tests/api/test_predictor.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0295ba...d2457ce. Read the comment docs.

@adelavega adelavega merged commit 446c705 into master Jan 15, 2020
@adelavega adelavega deleted the enh/ee branch January 29, 2021 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add on-the-fly predictor_event creation for extracted events
2 participants