Dedupe auto contrasts #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s button don't add another copy to contrast list
|
Okay, tested it and looks good, but actually while we're at it, can you remove any transformations that apply to removed Predictors? |
Codecov Report
@@ Coverage Diff @@
## master #723 +/- ##
======================================
Coverage 85.8% 85.8%
======================================
Files 66 66
Lines 2965 2965
======================================
Hits 2544 2544
Misses 421 421Continue to review full report at Codecov.
|
|
Ok added! |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #678
Also when a predictor is removed from the predictors tab any contrast that includes it is also removed.