Dataset list refactor #724
Conversation
|
We could also add a manually curated |
Codecov Report
@@ Coverage Diff @@
## master #724 +/- ##
==========================================
- Coverage 85.8% 85.77% -0.03%
==========================================
Files 66 66
Lines 2965 2995 +30
==========================================
+ Hits 2544 2569 +25
- Misses 421 426 +5
Continue to review full report at Codecov.
|
…olumn, update api and typescript to expect modality from api
|
Author list sometimes was one long string. I manually updated these entries, as these are technically BIDS errors which need to be corrected prior to ingestion. In the future, check this field prior to ingestion. |
|
…uns_subject and avg_run_duration to Task model/schema
|
@rwblair fyi the server is live with the changes in this branch |
|
The API, I mean. |
… issue with number of selected runs when there are multiple tasks per dataset
|
I didn't end up putting any of the task information in the dataset expansion, just extended the task table to include it. No real formatting going on in expansion still, will only show mean age, percent female, and known issues if present. |
…ne task, since the task and runs won't be auto selected then. fixes #707
|
I actually think the Task information might be good where it is now that I've looked at it. My main gripes now will be aesthetic ones, but I may play around with it myself and see if I can think of other ideas. Mostly I just want to keep the display as clean as possible, while still providing additional information. |
|
|
I think I'm going to change I think for missing demographics we should put Let's also put a complete author listing under the + button (or maybe what we were doing before that showed ~5 others, with Let's preface the external link with something like Curation wise, I'll do the following:
Other ideas for other fields (that as in OpenNeuro for example)
|
…to dataset_list_rf
…phic information when not present. Update front end type for dataset to use summary and long_description fields
…to dataset_list_rf
|
Snuck in a patch for #717 |
…t TR from wraping. Mess with spand width to bring %female in towards mean age
…to dataset_list_rf
…to dataset_list_rf
…to dataset_list_rf
|
@rwblair one minor thing here Looks like when I unselect all runs, then select all again (in SherlockMerlin, with a task selected), the following happens:
|
|
Otherwise, eveything else LGTM, |
Looks great!
Everything else looking awesome! |
|
@rbroc I think in the Schematic Narratives, the audio only clips are played during the video stimulation within a run, so we're good. |
Closes #689
Let's also take care of #707 and #692 here.
For now just made these small backend changes:
mimetypefor datasets are now sorted by id, so that the oldest stimuli for each dataset goes first. Let's display the mimetype for only that one, as that is the original stimulus.TRis now shown for tasks under datasets route.