New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate warnings in report #725
Conversation
Codecov Report
@@ Coverage Diff @@
## master #725 +/- ##
=========================================
Coverage ? 85.87%
=========================================
Files ? 67
Lines ? 3022
Branches ? 0
=========================================
Hits ? 2595
Misses ? 427
Partials ? 0
Continue to review full report at Codecov.
|
…to report_warnings
…to report_warnings
Cool, it's working on the backend |
Alright, all is looking good. @rwblair please take a look next week and test & see if there's a cleaner way to do things. On the backend, still need to catch errors in the warnings module. Uncaught errors in Reports will result in Report hanging indefinitely. Otherwise, just need to add more warnings. For now, focus on checking if |
|
…to report_warnings
Closes #441 #704
Adds a
warnings
field to theReport
model. This field is update if any warnings are generated, and even if the Report ends up crashing.We should display these above the traceback using ant's alerts, such as this one:
If each warning is pretty short, we should be able to stack them above the traceback (if any).
Sometimes warnings will be spit out even when there are no errors and the design matrix is compiled.
Maybe they can go after
Correlation Matrix
? These are not going to be subject specific so they should not be included within a Run tab.I will next add a warning for #704 to test this out.