Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate categorical variables #731

Merged
merged 2 commits into from Jan 28, 2020
Merged

Deactivate categorical variables #731

merged 2 commits into from Jan 28, 2020

Conversation

adelavega
Copy link
Collaborator

Closes #728

  • Deactivates categorical variables by default
  • Adds active as kwargs to PredictorList resource/API route

This should not change how pyNS or the frontend client interactive with the API.

@codecov-io
Copy link

codecov-io commented Jan 28, 2020

Codecov Report

Merging #731 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #731      +/-   ##
==========================================
+ Coverage   85.87%   85.87%   +<.01%     
==========================================
  Files          67       67              
  Lines        3022     3023       +1     
==========================================
+ Hits         2595     2596       +1     
  Misses        427      427
Impacted Files Coverage Δ
neuroscout/resources/predictor.py 89.02% <100%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f062f0c...5fb8fbb. Read the comment docs.

@adelavega adelavega merged commit 7759c59 into master Jan 28, 2020
@adelavega adelavega deleted the deactivate_categorical branch January 28, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to handle categorical variables?
2 participants