Fix extractor source not updating in certain cases. #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Use deep equal instead of array length to determine if this happened. Fix logic around setting selectedtask with multiple tasks present
Codecov Report
@@ Coverage Diff @@
## master #783 +/- ##
=======================================
Coverage 83.07% 83.07%
=======================================
Files 63 63
Lines 2854 2854
=======================================
Hits 2371 2371
Misses 483 483 Continue to review full report at Codecov.
|
|
cool. ready for review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
memoize setting the extractor source, update only on predictor change. Use deep equal instead of array length to determine if this happened. Fixed another issue around setting selectedTaskId not working when loading an analysis from a dataset with multiple tasks.
fixes #708