Add user profiles #791
Add user profiles #791
Conversation
|
Should we let users upload a profile pic besides their google one? |
…resource. initial fronend api changes and compoenets.
…es to auth state when profile gets loaded. add function to put profile changes to api
|
Minor thing but I'm not sure why your update to the user schema broke the tests. I'm not sure if the test that's failing makes that much sense anyways. Basically, the schema should reject partial updates, unless the mandatory fields are included. But it looks like now it's allowing a single field update.... not sure why that's changed but it looks OK |
… and auth store from the results.
…acked outside of auth store we do the getting else where. allow for setting local storage items on auth store update
…pdate authstore when putting profile changes to api
…formation. Update various field names to match what the api returns exactly. Don't display actions column for analysis list if not logged in.
|
@adelavega last two commits have public profiles. Currently not linked anywhere. I have them using the user id from the database for both the front end and api routes. Do we want to identify them by some other method? Email is guaranteed to be unique but encoded in the url its a lot more busy looking than just an id. We had also talked about generating another type of id, maybe on like for analyses? Fixed the clone being visible for non logged in users. Also right now it only displays fields for which there are values in the user profile, not sure if we want to default to just showing empty entries. Finally I still need to make the twitter handle and personal site and actual link. |
|
Looking pretty good. I say we have the dropdown menu have a link to "Your Profile" and if you're viewing your own profile, there's a link to edit your profile. Maybe we also add a link back from the profile editor to your public profile. I'd be nice to see a bit more visual structure, like maybe some lines between the fields, or little emojis preceding each field (again I'm totally open to ripping off github) For now, I'd be OK with sticking to these obscure IDs, we can tackle migrating to user names in a separate PR. We should soon also add references to people in the public analysis listing (and review tab somewhere), which links to people's profiles. |
…egrityerror, display username in use error on profile edit form
…ntend for profile edit
adelavega
force-pushed
the
add_profiles
branch
from
da08079
to
01abe56
Compare
Codecov Report
@@ Coverage Diff @@
## master #791 +/- ##
==========================================
+ Coverage 83.13% 83.25% +0.11%
==========================================
Files 63 63
Lines 2870 2902 +32
==========================================
+ Hits 2386 2416 +30
- Misses 484 486 +2
Continue to review full report at Codecov.
|
Merge Summary (8/14/2020):
user_namefor all users. Set to default value based on name, but can be changed by user.WIP PR starting #159
Institutionfield to dbFrontend todo:
Institutionto sign up sheet formMy Accountpage where users can edit their informationQuestions:
Anonymousprivacy mode. If this is set to true inMy Accountthen their profile would be private to others, and any analyes shared by them would not show their name. I think this is probably unnecessary as users can just keep their analyses private, and theres no listing of profilesusername? Currently we storegoogle_idto this is a starting point. We could force people to use a username, which for now we could set to the first part of their email. This could be what is displayed instead of their name, and would be the URL for profile pages.