Speed up and fix My Analyses #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm also seeing scenarios where it says "No Analyses" even when I know that is not the case. |
|
@rwblair let's take a look on monday. I think there's actually something funky with this, and I'm seeing it across accounts, so I don't think it's just my huge analysis list, like I thought earlier. the upside is once we get this fixed, it should actually be quite quick compared to before. |
|
Unfortunately looks like this is behavior from our recent PR... so you were right @rwblair just had to merge to find the bugs. I reverted the server to a previous state for now as the "My Analysis" listing is pretty important. |
|
Good to go, app feels snappy. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/myanalyses is quite slow right now.
One improvement is to only return the fields that matter for the listing, for both private and public analyses.
This seems to reduce the data transfered by 5x and speed up the query by up to 10x.
However, I'm still getting a situation where the query hangs on the frontend, and I only see a spinning icon.
I tested this with an account with only a few analyses, so I don't think having too many analyses is the issue.
Instead, I think there's scenarios where the logic goes awry and it just hangs.