New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Marshamallow 3, also upgrade webargs flask_apispec #816
Conversation
@rwblair I think I was able to upgrade to marshmallow 3! It wasn't as bad as I thought fortunately, just a couple of tricky changes. Do you mind testing this against the frontend locally on your dev machine? If it looks good I'll test on live server. |
Codecov Report
@@ Coverage Diff @@
## master #816 +/- ##
==========================================
- Coverage 83.25% 83.16% -0.10%
==========================================
Files 63 63
Lines 2902 2886 -16
==========================================
- Hits 2416 2400 -16
Misses 486 486
Continue to review full report at Codecov.
|
Oh, right. The main thing that might still not work is the multi-part file upload. Need to test that out still... |
Fixed the file upload by doing a double Marshmallow Schema that ignores extra arguments. This accept all arguments, but still appropriately documents them. |
We're using a fairly old version of Marshmallow, so I'm upgrading to v3, and upgrading
webargs
flask_apispec
as well.In the process, I also updated the Dockerfile to buster from stretch.