September grab bag

[rwblair]

• Timestamp - remove time from sort, but add full time stamp to report
• Closes User generated predictors not showing up in predictor list #813
• Closes Remove promise resolution from constructors #619
• Miscellanous bugs: collection list failing with no uploaded predictors, api call to neurovault failing

[adelavega]

Looks like the date in the analysis listing is only date-month, why not day? I think just classic MM-DD-YY would be best probably

Minor comment about the last modified date, it's really close to the (i) hover thing, which makes them seem related.
I would say either mom the date into the body, or put the last modified date into a "Tag" to visually separate them.
It made me expect that the (i) was going to tell me about the last modified date when its just general info.

By Tag I like the way "PASSED" is displayed on the Status tab.

We could also just put the last modified date on the Status tab if there's more room there.

[codecov-commenter]

Codecov Report

Merging #819 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #819      +/-   ##
==========================================
+ Coverage   83.23%   83.31%   +0.07%     
==========================================
  Files          63       63              
  Lines        2899     2912      +13     
==========================================
+ Hits         2413     2426      +13     
  Misses        486      486              

Impacted Files	Coverage Δ
neuroscout/resources/predictor.py	90.62% <100.00%> (+1.46%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd9f290...8e4e1d9. Read the comment docs.

[rwblair]

Right now for date formatting I have dd-mm-yyyy

The world is a big scary place and we Americans are not making it any easier:
https://en.wikipedia.org/wiki/Date_format_by_country

[adelavega]

loaded on server for testing. so far looks good to me, although tests are failing.

@rwblair can you tag all the issues addressed in the initial comment?

[adelavega]

Tests fixed, if you can just list those issues and I can verify all is well I think we're ready to merge

[rwblair]

Just the note that is in progress in .8 project, #813 and potentially #619 when task selecting is implemented for predictor uploads. There were a few bugs that didn't have issues that were fixed (collection list failing with no uploaded predictors, api call to neurovault failing)