Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various UI improvements + Pybids 0.12.3 #837

Merged
merged 45 commits into from Oct 26, 2020
Merged

Various UI improvements + Pybids 0.12.3 #837

merged 45 commits into from Oct 26, 2020

Conversation

adelavega
Copy link
Collaborator

@adelavega adelavega commented Oct 14, 2020

@adelavega
Copy link
Collaborator Author

@rwblair can you also tackle #826 on this one?

@adelavega
Copy link
Collaborator Author

For the n/a problem:
Scale - make replace after scale default value
Add docs in warning about doing this.

@adelavega
Copy link
Collaborator Author

Fixed #821 by using new version of pybids which has a fix for this. Also bumped to latest pybids version. Need to update the PIN once the official release comes through.

We should also address the fact that correlation matrix plots are not showing up in this PR.

@rwblair
Copy link
Collaborator

rwblair commented Oct 21, 2020

f02e32e fixes #826

@adelavega
Copy link
Collaborator Author

@rwbair just a reminder to tackle #824 tomorrow if you get a chance (in this PR if it's still open, thanks).

@adelavega
Copy link
Collaborator Author

adelavega commented Oct 23, 2020

Just to recap things left to do:

  • Waiting to @tyarkoni to review my pybids PR, so we can cut a new release and PIN it here

@adelavega adelavega changed the title WIP - Various small improvements Various UI improvements Oct 23, 2020
@adelavega adelavega changed the title Various UI improvements Various UI improvements + Pybids 0.12.3 Oct 24, 2020
@codecov-io
Copy link

codecov-io commented Oct 26, 2020

Codecov Report

Merging #837 into master will decrease coverage by 0.45%.
The diff coverage is 61.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #837      +/-   ##
==========================================
- Coverage   82.55%   82.09%   -0.46%     
==========================================
  Files          63       63              
  Lines        2917     2960      +43     
==========================================
+ Hits         2408     2430      +22     
- Misses        509      530      +21     
Impacted Files Coverage Δ
neuroscout/core.py 67.74% <ø> (ø)
neuroscout/resources/__init__.py 100.00% <ø> (ø)
neuroscout/resources/analysis/__init__.py 100.00% <ø> (ø)
neuroscout/resources/analysis/reports.py 51.11% <0.00%> (-0.77%) ⬇️
neuroscout/resources/dataset.py 100.00% <ø> (ø)
neuroscout/tasks/utils/warnings.py 73.52% <30.00%> (-14.94%) ⬇️
neuroscout/resources/analysis/endpoints.py 88.81% <31.25%> (-6.36%) ⬇️
neuroscout/resources/predictor.py 86.91% <50.00%> (-3.81%) ⬇️
neuroscout/utils/db.py 83.56% <62.50%> (-2.81%) ⬇️
neuroscout/tasks/utils/build.py 90.90% <91.66%> (+5.80%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a846313...7adfb03. Read the comment docs.

@adelavega adelavega merged commit 4948699 into master Oct 26, 2020
@adelavega adelavega deleted the oct_small_fixes branch October 26, 2020 18:46
@adelavega adelavega restored the oct_small_fixes branch October 26, 2020 18:46
@adelavega adelavega deleted the oct_small_fixes branch January 29, 2021 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants