New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Extractor description API route #878
Conversation
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Codecov Report
@@ Coverage Diff @@
## master #878 +/- ##
==========================================
- Coverage 84.70% 84.53% -0.18%
==========================================
Files 57 59 +2
Lines 2858 2883 +25
==========================================
+ Hits 2421 2437 +16
- Misses 437 446 +9
Continue to review full report at Codecov.
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
This is what the output looks like, what do you think @rwblair
|
@tyarkoni what do you think? I wanted to avoid over complicating our db, and doing annoying migrations just to be able to add this information. It seems that if we keep it all in pliers, it also incentives us to have a good description in only one place. |
44d0f8f
to
d2b92af
Compare
For #820 #870 need API route with descriptions for extractors.
Instead of adding to the db and over-complicating, I decided to just scrape the doc strings from Pliers and return via API. We can cache this route to ensure adequate performance.