Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set scale to default to false on report plots if we get a report without scaling informaiton #917

Merged
merged 4 commits into from Apr 30, 2021

Conversation

rwblair
Copy link
Collaborator

@rwblair rwblair commented Apr 30, 2021

After merging master locally and then making this branch with a commit only touching Reports.tsx, yarn start is failing at Status.tsx error for some reason.

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2021

Codecov Report

Merging #917 (d556b27) into master (e38fd57) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #917   +/-   ##
=======================================
  Coverage   83.14%   83.14%           
=======================================
  Files          62       62           
  Lines        3103     3103           
=======================================
  Hits         2580     2580           
  Misses        523      523           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e38fd57...d556b27. Read the comment docs.

@cypress
Copy link

cypress bot commented Apr 30, 2021



Test summary

0 7 0 0


Run details

Project Neuroscout
Status Failed
Commit d556b27
Started May 4, 2021 9:59 PM
Ended May 4, 2021 10:00 PM
Duration 00:47 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️


Failures

analysis_builder.spec.js Failed
1 Analysis Builder > analysis builder
home_spec.js Failed
1 The Home Page > successfully loads
2 The Home Page > navigation bar contents
3 The Home Page > splash page contents
4 The Home Page > test sign up button 1
5 The Home Page > test sign up button 2
6 The Home Page > test sign in button

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Apr 30, 2021



Test summary

0 7 0 0


Run details

Project Neuroscout
Status Failed
Commit bdd2c15 ℹ️
Started Apr 30, 2021 6:16 PM
Ended Apr 30, 2021 6:17 PM
Duration 00:54 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️

Failures are unavailable for this run. For more information, see the Cypress Dashboard


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@adelavega adelavega merged commit 284aea2 into master Apr 30, 2021
@adelavega adelavega deleted the 915_no_scale_by_default branch April 30, 2021 18:52
@rwblair rwblair restored the 915_no_scale_by_default branch May 4, 2021 21:54
@adelavega adelavega deleted the 915_no_scale_by_default branch September 22, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants