Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gzip files, by serving w/ nginx not flask #925

Merged
merged 1 commit into from May 4, 2021
Merged

Gzip files, by serving w/ nginx not flask #925

merged 1 commit into from May 4, 2021

Conversation

adelavega
Copy link
Collaborator

Addresses #908 by adding gzip to Nginx.

The problem was the wrong mimetype was issued for json files, and flask served the main index.html file, not nginx.

@codecov-commenter
Copy link

codecov-commenter commented May 4, 2021

Codecov Report

Merging #925 (48e06f5) into master (284aea2) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #925      +/-   ##
==========================================
+ Coverage   83.14%   83.16%   +0.01%     
==========================================
  Files          62       62              
  Lines        3103     3100       -3     
==========================================
- Hits         2580     2578       -2     
+ Misses        523      522       -1     
Impacted Files Coverage Δ
neuroscout/core.py 67.85% <ø> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 284aea2...48e06f5. Read the comment docs.

@cypress
Copy link

cypress bot commented May 4, 2021



Test summary

0 7 0 0


Run details

Project Neuroscout
Status Failed
Commit 48e06f5
Started May 4, 2021 10:02 PM
Ended May 4, 2021 10:03 PM
Duration 00:51 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️


Failures

analysis_builder.spec.js Failed
1 Analysis Builder > analysis builder
home_spec.js Failed
1 The Home Page > successfully loads
2 The Home Page > navigation bar contents
3 The Home Page > splash page contents
4 The Home Page > test sign up button 1
5 The Home Page > test sign up button 2
6 The Home Page > test sign in button

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented May 4, 2021



Test summary

0 7 0 0


Run details

Project Neuroscout
Status Failed
Commit a822559 ℹ️
Started May 4, 2021 10:03 PM
Ended May 4, 2021 10:03 PM
Duration 00:46 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️


Failures

analysis_builder.spec.js Failed
1 Analysis Builder > analysis builder
home_spec.js Failed
1 The Home Page > successfully loads
2 The Home Page > navigation bar contents
3 The Home Page > splash page contents
4 The Home Page > test sign up button 1
5 The Home Page > test sign up button 2
6 The Home Page > test sign in button

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@adelavega adelavega merged commit 5dbe14a into master May 4, 2021
@adelavega adelavega deleted the gzip branch May 4, 2021 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants