Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add distinct extractor route #931

Merged
merged 4 commits into from May 7, 2021
Merged

add distinct extractor route #931

merged 4 commits into from May 7, 2021

Conversation

adelavega
Copy link
Collaborator

@adelavega adelavega commented May 6, 2021

Closes #923 + adds a route for it. This would help in documentation as well

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2021

Codecov Report

Merging #931 (10b46ff) into master (f1b2f72) will decrease coverage by 0.43%.
The diff coverage is 35.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #931      +/-   ##
==========================================
- Coverage   83.14%   82.71%   -0.44%     
==========================================
  Files          62       63       +1     
  Lines        3103     3129      +26     
==========================================
+ Hits         2580     2588       +8     
- Misses        523      541      +18     
Impacted Files Coverage Δ
neuroscout/core.py 67.74% <ø> (ø)
neuroscout/utils/misc.py 11.76% <11.76%> (ø)
neuroscout/resources/extractor.py 84.37% <70.00%> (-6.93%) ⬇️
neuroscout/resources/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1b2f72...10b46ff. Read the comment docs.

@cypress
Copy link

cypress bot commented May 6, 2021



Test summary

0 7 0 0


Run details

Project Neuroscout
Status Failed
Commit 8fbc351 ℹ️
Started May 6, 2021 10:44 PM
Ended May 6, 2021 10:45 PM
Duration 00:41 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️


Failures

analysis_builder.spec.js Failed
1 Analysis Builder > analysis builder
home_spec.js Failed
1 The Home Page > successfully loads
2 The Home Page > navigation bar contents
3 The Home Page > splash page contents
4 The Home Page > test sign up button 1
5 The Home Page > test sign up button 2
6 The Home Page > test sign in button

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented May 6, 2021



Test summary

0 7 0 0


Run details

Project Neuroscout
Status Failed
Commit 10b46ff
Started May 6, 2021 10:45 PM
Ended May 6, 2021 10:45 PM
Duration 00:52 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️


Failures

analysis_builder.spec.js Failed
1 Analysis Builder > analysis builder
home_spec.js Failed
1 The Home Page > successfully loads
2 The Home Page > navigation bar contents
3 The Home Page > splash page contents
4 The Home Page > test sign up button 1
5 The Home Page > test sign up button 2
6 The Home Page > test sign in button

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@adelavega adelavega merged commit 0186d5a into master May 7, 2021
@adelavega adelavega deleted the ext_count branch May 7, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add script to check extractor completeness
2 participants