Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use run id as a string for its value in report select dropdown. #941

Merged
merged 1 commit into from May 26, 2021

Conversation

rwblair
Copy link
Collaborator

@rwblair rwblair commented May 20, 2021

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2021

Codecov Report

Merging #941 (03ff4b5) into master (28601a7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #941   +/-   ##
=======================================
  Coverage   82.73%   82.73%           
=======================================
  Files          63       63           
  Lines        3128     3128           
=======================================
  Hits         2588     2588           
  Misses        540      540           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28601a7...03ff4b5. Read the comment docs.

@cypress
Copy link

cypress bot commented May 20, 2021



Test summary

7 0 0 0Flakiness 0


Run details

Project Neuroscout
Status Passed
Commit 03ff4b5
Started May 25, 2021 11:45 PM
Ended May 25, 2021 11:46 PM
Duration 00:57 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented May 20, 2021



Test summary

7 0 0 0Flakiness 0


Run details

Project Neuroscout
Status Passed
Commit 88ce85f ℹ️
Started May 20, 2021 7:05 PM
Ended May 20, 2021 7:06 PM
Duration 00:58 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@adelavega
Copy link
Collaborator

This fix works!
Tests need to be updated.

Also including #942 in this PR.

@adelavega
Copy link
Collaborator

@rwblair since you mentioned fixing the scale issue was going to be more in depth, then instead let's merge this for just this fix

however, looks like tests are not passing, any clues?

@rwblair
Copy link
Collaborator Author

rwblair commented May 26, 2021

Guess my increased timeouts still aren't long enough for a ci environment, reran jobs and it passed.

@rwblair rwblair merged commit 1c53cd1 into master May 26, 2021
@adelavega adelavega deleted the 914_fix_hanging_reports branch May 26, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants